NameError: name 'basestring' is not defined - Githubissues

hakril / PythonForWindows

A codebase aimed to make interaction with Windows and native execution easier

BSD 3-Clause "New" or "Revised" License

569 stars 114 forks source link

NameError: name 'basestring' is not defined #15

Closed lucasg closed 4 years ago

lucasg commented 4 years ago

Hi,

There still some basestring uses in the codebase without the corresponding pycompat import, making it raise an Exception when used on python3.

Files impacted :

windows/winobject/event_trace.py
windows/debug/breakpoints.py
windows/crypto/cryptmsg.py
windows/utils/improved_buffer.py
windows/utils/pythonutils.py
windows/winobject/service.py
windows/debug/symbols.py
windows/winproxy/ntdll.py
windows/security.py
windows/winobject/event_log.py
windows/winobject/process.py

I didn't test all of them, only several (event_log.py and process.py)

hakril commented 4 years ago

Hi,

Thanks for the issue, this is indeed problematic. I may have overlooked that as I still do not use PFW with py3 very often. Moreover it demonstrated a lack of testing in some of these features.

I have added tests that should trigger each of the reported missing reference as well as the corresponding fixes.

Feel free to reopen the issue if some are still missing.