search

hakril / PythonForWindows

A codebase aimed to make interaction with Windows and native execution easier
BSD 3-Clause "New" or "Revised" License
573 stars 112 forks source link

add x86 mnemonics and alias to Jz #20

Closed srounet closed 3 years ago

srounet commented 3 years ago

Add some x86 Instructions to simple_x86 along with some basic testing for coverage.

hakril commented 3 years ago

Hi,

Thank you for the PR. Could you please also add the Pushfd, Popfd & Jz instructions to the simple_x64 file please ? I would like to keep the instruction set available to both bitness somewhat similar. If am not mistaken Pushad/Popad do not exist in x64 so we can ignore these in simple_x64 Finally I prefer to avoid the Popal/Pushal aliases as no reference to it can be found in the intel manual (I used https://www.intel.com/content/dam/www/public/us/en/documents/manuals/64-ia-32-architectures-software-developer-instruction-set-reference-manual-325383.pdf) as a reference.

srounet commented 3 years ago

Thank you for your feedback as discussed I removed the pushal/popal from x86 and used expected_result within tests. Pushfd, Popfd and Jz have also been added to x64 instructions.

Feel free to suggest any changes.

hakril commented 3 years ago

Thank you for the PR and the following fixes. Do not hesitate if you have any other issues or proposition for improvement