haku / Onosendai

A multi-column social network client for Android
Apache License 2.0
18 stars 11 forks source link

Show quoted tweets in-line #171

Closed haku closed 8 years ago

haku commented 9 years ago

Still to do:

haku commented 9 years ago

Bug to fix: If the quoted tweet has a picture the list may 'jump' slightly as the UI realises slightly too late it should have left some space to put the pic in. This will also happen if the quoted tweet text is long. Need to make it so the quoted tweet always has the same, predictable height, no matter the content (like inline pics do).

haku commented 9 years ago

To do: do not eat click when expansion has no effect. Also ensure expanded state is reset when view is recycled.

haku commented 9 years ago

Basically done other than for short quoted tweets it leaves too much space, e.g.: screenshot from 2015-10-04 11 04 18

This is require as the quoted tweet is loaded async and the UI has to guess in advance how much space to leave to avoid the list 'jumping'. Though could be fixed by denormalising more data into the main DB table, e.g. hint there is a pic and switch between two different preset heights.

Or could denormalise the entire quoted tweet and measure exactly.

One to ponder.