hal / berg

HAL test suite based on Cypress
https://hal.github.io/berg/
Apache License 2.0
1 stars 12 forks source link

[EAPQE-82][hal#34] Add transactions subsystem test coverage #96

Closed OndrejGerzicak closed 1 year ago

OndrejGerzicak commented 1 year ago

Possible follow-ups:

Possible web console issue:

kstekovi commented 1 year ago

I don't see coverage for: https://github.com/hal/testsuite.next/blob/master/tests-configuration-transaction/src/test/java/org/jboss/hal/testsuite/test/configuration/transaction/TransactionFinderTest.java

Does it have a some reason?

kstekovi commented 1 year ago

could you please add transaction folder into github workflows?

OndrejGerzicak commented 1 year ago

I don't see coverage for: https://github.com/hal/testsuite.next/blob/master/tests-configuration-transaction/src/test/java/org/jboss/hal/testsuite/test/configuration/transaction/TransactionFinderTest.java

Does it have a some reason?

My understanding was that the finder test is something like a setup. Also in for example batch subsystem I don't see it either even though it is in legacy TS: https://github.com/hal/testsuite.next/blob/master/tests-configuration-batch/src/test/java/org/jboss/hal/testsuite/test/configuration/batch/BatchFinderTest.java

kstekovi commented 1 year ago

I don't see coverage for: https://github.com/hal/testsuite.next/blob/master/tests-configuration-transaction/src/test/java/org/jboss/hal/testsuite/test/configuration/transaction/TransactionFinderTest.java Does it have a some reason?

My understanding was that the finder test is something like a setup. Also in for example batch subsystem I don't see it either even though it is in legacy TS: https://github.com/hal/testsuite.next/blob/master/tests-configuration-batch/src/test/java/org/jboss/hal/testsuite/test/configuration/batch/BatchFinderTest.java

The test is testing navigation from Home page to a Transaction manager. The other test which you already added start in the transaction manager.

kstekovi commented 1 year ago

All git check and new tests passed. The code LGTM. Merge! @OndrejGerzicak Thanks for the contribution.