hal3 / macarico

learning to search in pytorch
MIT License
111 stars 12 forks source link

Why is this called InverseSigmoidAnnealing? #3

Closed timvieira closed 7 years ago

timvieira commented 7 years ago

https://github.com/hal3/macarico/blob/master/macarico/annealing.py#L32

I assume it's "inverse" because of the missing minus? However, "inverse sigmoid" is logit... I think "reverse sigmoid" is a better name.

hal3 commented 7 years ago

Yeah go ahead and change. I think I was copying the Selective Sampling paper, but I might've gotten it wrong.

hal3 commented 7 years ago

Sorry I mean scheduled sampling

timvieira commented 7 years ago

I changed the name to NegativeSigmoidAnnealing