search

hal3 / macarico

learning to search in pytorch
MIT License
111 stars 12 forks source link

requirements? #39

Open andreasvlachos opened 5 years ago

andreasvlachos commented 5 years ago

Greetings,

Thanks for putting this together, it looks very exciting! I had some trouble figuring out the requirements, could you maybe put a file for them to make sure I am not missing something obvious? Or are they stated somewhere?

Best, Andreas

hal3 commented 5 years ago

it should only require pytorch unless i forgot something. what errors are you getting?

xkianteb commented 5 years ago

What branch are you using?

--- Thanks Kianté

On Wed, Apr 10, 2019 at 12:18 PM Hal Daumé III notifications@github.com wrote:

it should only require pytorch unless i forgot something. what errors are you getting?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hal3/macarico/issues/39#issuecomment-481759626, or mute the thread https://github.com/notifications/unsubscribe-auth/AC_IlMb0J8zeJHRK_naXB8FvPjLal546ks5vfg7MgaJpZM4cnsvw .

andreasvlachos commented 5 years ago

Hi, thanks for the quick response. I am using the master branch. Which python version should I use? I think the errors might be related to that.

hal3 commented 5 years ago

I’m currently running python 3.5.4 with torch 0.4.1.

If you go to the tests directory and run python test_randomly.py what happens?

From: Andreas Vlachos notifications@github.com Sent: Thursday, 11 April, 2019 6:40 AM To: hal3/macarico macarico@noreply.github.com Cc: Hal Daumé III hal3@microsoft.com; Comment comment@noreply.github.com Subject: Re: [hal3/macarico] requirements? (#39)

Hi, thanks for the quick response. I am using the master branch. Which python version should I use? I think the errors might be related to that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fhal3%2Fmacarico%2Fissues%2F39%23issuecomment-482063065&data=02%7C01%7Chal3%40microsoft.com%7Cc3bdbc8f7b5d4911aefe08d6be6a09d5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636905759973171341&sdata=fT%2Bt4G9229V7ZeX6TDmh6szGPISx26epEopcNgFzeAg%3D&reserved=0, or mute the threadhttps://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABRc8bvxDiy08BHPmyF_ELDlACJ0ZvO9ks5vfxD6gaJpZM4cnsvw&data=02%7C01%7Chal3%40microsoft.com%7Cc3bdbc8f7b5d4911aefe08d6be6a09d5%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636905759973171341&sdata=knzXlM0lJw6brsJP8jzCH%2BQSzvtBT%2FuvixMbn8eixPU%3D&reserved=0.

andreasvlachos commented 5 years ago

Hi, I built a conda environment with these (might be good to specify the pytorch version as the default download is 1.0), run: python setup.py install, installed progressbar with conda install progressbar2 (otherwise it wants to downgrade to python2) and when running python test_randomly.py I get: ImportError: No module named 'macarico.lts' I checked and I can import macarico fine from the terminal. What am I missing? Thanks!

bgalbraith commented 5 years ago

Hi @andreasvlachos! I've been working through the codebase as well and I've run into some similar issues (conda environment, python 3.7, pytorch 1.0). I've been going through the exercise of refactoring the code for this environment as well as updating the old tests that were from an earlier iteration of the code and now break if you try to run them as is.

One thing I found that helps is to install the project into your conda environment by running pip install -e . This seems to clear up the macarico import errors.

Cheers, Byron

bgalbraith commented 5 years ago

Also, test_randomly.py won't work as it is trying to import modules in the macarico/data package which don't exist: synthetic and types. All folders named data are ignored by a rule in .gitignore, so maybe these exit on @hal3's local machine but never got pushed to the repo ;)

A test that should run as is is test_concentration.py

andreasvlachos commented 5 years ago

@bgalbraith thanks for the tips. Got snowed under other work, but I will get back on this as I am very interested.

xkianteb commented 5 years ago

I can help you guys with this issues after the NeurIps deadline :)

On Wed, May 8, 2019 at 6:38 AM Andreas Vlachos notifications@github.com wrote:

@bgalbraith https://github.com/bgalbraith thanks for the tips. Got snowed under other work, but I will get back on this as I am very interested.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hal3/macarico/issues/39#issuecomment-490437179, or mute the thread https://github.com/notifications/unsubscribe-auth/AAX4RFHB57WJUXUGCBZLV6TPUKUQTANCNFSM4HE6ZPYA .