Missing PHP-Doc PathNotFoundException

Jannig89 commented 1 year ago

On Items.php

/**
     * @return \Generator
     */
    #[\ReturnTypeWillChange]
    public function getIterator()
    {
        return $this->parser->getIterator();
    }

please add @throws PathNotFoundException as it will not be recognised in PHP-Storm as Throwable Exception.

halaxa commented 1 year ago

Hi, I turned this issue into PR, @Jannig89 (sorry, bad idea, your original comment was posted on my behalf). Can you verify it works for you?

codecov-commenter commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1b3aa89) 100.00% compared to head (8a6178d) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #109 +/- ## =========================================== Coverage 100.00% 100.00% Complexity 184 184 =========================================== Files 17 17 Lines 526 526 =========================================== Hits 526 526 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

halaxa / json-machine

Missing PHP-Doc PathNotFoundException #109

Codecov Report