search

halbgut / rss-o-bot

A FOSS RSS Bot alternative
9 stars 4 forks source link

fix(helpers): transformFilter returning incorrect 'kind' #13

Closed ZakYahi closed 5 years ago

ZakYahi commented 6 years ago

The filters were not working properly, notifications were sent for the wrong RSS items. According to the tests in "src/unit/poll.js", 'kind' should be inverted to work properly.

ZakYahi commented 6 years ago

The "acceptance › index › add" test doesn't pass because the feed is empty because of the filter. If it's empty, the display : image cannot be shown and the test fails trying to compare it.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 86.538% when pulling 7d8c95931e9ad8b719667e7b30ffe5faf4cddb4c on MitsuhideA:master into b75acca941dfff27010dd0a1068588078b343d88 on Kriegslustig:master.

ZakYahi commented 6 years ago

@Kriegslustig could you please look at this when you have time? I would like to know if this is ok 😄