search

halcyon / asdf-java

A Java plugin for asdf-vm.
MIT License
455 stars 86 forks source link

Change in Naming of Releases (Unknown release: adopt-openjdk-11.0.6+10) #100

Open adyang opened 4 years ago

adyang commented 4 years ago

Hi,

I am not sure if this is intentional or by mistake, but it seems that the names of the releases have changed from adopt-openjdk-11.0.6+10 to adoptopenjdk-11.0.6+10. Also it seems that some versions are missing such as adopt-openjdk-8u242-b08.

The context is running asdf install java adopt-openjdk-11.0.6+10 based on the java versions that are previously saved into a .tool-versions file that is checked into vcs. The failure is on a CI job that runs some dotfiles script for testing purposes.

Think this would also impact projects that use a local .tool-versions that specify a specific version of java.

prakhunov commented 4 years ago

Thankfully this doesn't affect our CI since I use my own asdfdocker image with plugins preinstalled, but this is very annoying locally.

For now I did this locally:

asdf plugin-update java b050643a2d86aa27c5c1d1aa850fdc83435f2f6d

To use the commit before all version name changes.

delgurth commented 3 years ago

@joschi should we change your repository to contain a "-" between the adopt and openjdk? Or will we just wait for the Eclipse Adoption name switch, and see if all old releases will be rebranded?

I also introduced a breaking change to the naming with https://github.com/halcyon/asdf-java/pull/140 but I don't see a nice way to deal with this.

joschi commented 3 years ago

should we change your repository to contain a "-" between the adopt and openjdk?

@delgurth Since the change was introduced over 9 months ago I really wouldn't want to break consumers again. 😉

So I'm firmly against changing the names from adoptopenjdk-* to adopt-openjdk-*.

Or will we just wait for the Eclipse Adoption name switch, and see if all old releases will be rebranded?

Will they be rebranded? I was under the impression that only new JDK releases would be published under the new name (Temurin).

delgurth commented 3 years ago

@delgurth Since the change was introduced over 9 months ago I really wouldn't want to break consumers again. 😉

Agree, forgot to look how old this question was :(

Will they be rebranded? I was under the impression that only new JDK releases would be published under the new name (Temurin).

I sure hope not, but you never know.