halcyon / asdf-java

A Java plugin for asdf-vm.
MIT License
467 stars 86 forks source link

Fix the error 'already ends with semicolon' causing by the misuse of export #119

Closed jinmiaoluo closed 3 years ago

jinmiaoluo commented 3 years ago

fixes #91

halcyon commented 3 years ago

LGTM. Any thoughts @joschi ?

jinmiaoluo commented 3 years ago

@halcyon LGTM.

@jinmiaoluo Does this problem only exist in bash or should we update the other scripts too?

Sorry @halcyon, I don't familiar with Zsh/Fish. If anyone is familiar with Zsh/Fish 'PROMPT_COMMAND' kind thing. Welcome to submit your merge request.

joschi commented 3 years ago

Sorry @halcyon, I don't familiar with Zsh/Fish. If anyone is familiar with Zsh/Fish 'PROMPT_COMMAND' kind thing. Welcome to submit your merge request.

@jinmiaoluo That's fine. We can start with fixing the script for Bash. 😄

halcyon commented 3 years ago

Thank you!