Remove surplus `dirname` in set-java-home.bash

halcyon / asdf-java

A Java plugin for asdf-vm.

MIT License

455 stars 86 forks source link

Closed joschi closed 3 years ago

joschi commented 3 years ago

Refs #114 Closes #126

fcrespo82 commented 3 years ago

@joschi Sorry about that. I saw that you are already testing a fix.

This should be changed in fish and zsh too..

Actually, my function could be changed to return the absolute file path... not dir path...

then the rest should work as is.

Do you want me to do a proof of concept in another branch?

joschi commented 3 years ago

This should be changed in fish and zsh too..

@fcrespo82 @halcyon Done.

halcyon commented 3 years ago

Thanks @joschi and @fcrespo82