search

halcyon / asdf-java

A Java plugin for asdf-vm.
MIT License
454 stars 86 forks source link

Use fish builtin `realpath` #133

Closed CodingAnarchy closed 3 years ago

CodingAnarchy commented 3 years ago

The fish shell has a builtin realpath, which should be used for this.

The absolute_dir_path function doesn't work as it might be expected to, and instead just traps the user inside the JAVA_HOME directory.

See https://github.com/fish-shell/fish-shell/issues/7780 and closes https://github.com/halcyon/asdf-java/issues/130.

aaronsky commented 3 years ago

I can confirm this patch resolves the issue in my environment, in case you needed an additional data point.

CodingAnarchy commented 3 years ago

@halcyon Is there something we can do to fast-track this? It's a major issue for anyone using the fish shell with asdf-java.

halcyon commented 3 years ago

LGTM