Open timpur opened 2 years ago
@halcyon I think droping the jdk filter opened up the filter for static libs, something i didnt notice in #162 (introducting this bug)
Also am i right to lable alpine images as musl even though the meta data doesnt include that in the features ?
Looks like this is an attempt to address #167
@joschi what are your thoughts on this?
@halcyon I think droping the jdk filter opened up the filter for static libs, something i didnt notice in #162 (introducting this bug)
Also am i right to lable alpine images as musl even though the meta data doesnt include that in the features ?
This looks like an issue in the upstream project (https://github.com/joschi/java-metadata) and should be fixed there.
@timpur I think the changes regarding the alpine
infix wouldn't be necessary anymore once the release data was updated again.
The safeguard with filtering only for jdk
and jre
makes sense in every case. 👍
There was an issue in the upstream project providing the release metadata (https://github.com/joschi/java-metadata/issues/23).
The issue should be fixed since https://github.com/halcyon/asdf-java/commit/7e886b44a83c39d970b3243a1bb64cf49d335a97.
Okay ill update the pr
@joschi my worry is that instances like this
adoptopenjdk-17.0.1+12 OpenJDK17U-jdk_x64_alpine-linux_hotspot_17.0.1_12.tar.gz https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.1%2B12/OpenJDK17U-jdk_x64_alpine-linux_hotspot_17.0.1_12.tar.gz da4845987b3348da14338a0620ef7db25870e27670e82baebcc367fa9d17c7de
adoptopenjdk-17.0.1+12 OpenJDK17U-jdk_x64_linux_hotspot_17.0.1_12.tar.gz https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.1%2B12/OpenJDK17U-jdk_x64_linux_hotspot_17.0.1_12.tar.gz 6ea18c276dcbb8522feeebcfc3a4b5cb7c7e7368ba8590d3326c6c3efc5448b6
Which one is the right one to install ?
This plugin just picks the last one (since the names are the same) ? seems dangerous to me ?
Fixing an issue with new installs installing static libs not the actuall jdk
Renaming alpine images as musl ?