search

halcyon / asdf-java

A Java plugin for asdf-vm.
MIT License
460 stars 85 forks source link

Support multiple release types and EA builds #179

Closed jonatan-ivanov closed 1 year ago

jonatan-ivanov commented 2 years ago

Fixes #176 The feature relies on the java_release_type property in .asdf which is not documented at the moment in this PR but I'm going to add a few lines of docs once I get some feedback.

jonatan-ivanov commented 2 years ago

@joschi What do you think, should we merge this or are there other changes you want me to introduce?

jonatan-ivanov commented 2 years ago

@halcyon What do you think? ^

jonatan-ivanov commented 1 year ago

Hi @halcyon, Happy New Year, do you have any thoughts on this PR?

halcyon commented 1 year ago

@jonatan-ivanov Happy New Year! Sorry for the late response, LGTM!

bric3 commented 1 year ago

Thanks @jonatan-ivanov, sorry for looking at this so late.

jonatan-ivanov commented 1 year ago

@bric3 No problem. @halcyon Could you please take a look at this PR: https://github.com/halcyon/asdf-java/pull/198 it should fix an issue I made when I fixed issues raised in the comments on this PR.

tomwhoiscontrary commented 1 year ago

It would be nice to have some documentation for how to use this. This is what i eventually did, and it seemed to work:

echo java_release_type=ea >>~/.asdfrc
rm /tmp/asdf-java.cache/releases-*.tsv
asdf list all java
jonatan-ivanov commented 1 year ago

@tomwhoiscontrary I wanted to add docs in another PR after this was merged in but I forgot about it, here's a PR: https://github.com/halcyon/asdf-java/pull/206

What you did seems ok, I usually remove the whole cache dir, please check the PR and let us know what you think.