Use user home to integrate java for macOS

[rennsax]

Fix #213.

To integrate jdk at user home, set java_macos_integration_in_home = yes.

[mrmeszaros]

@rennsax Thanks for the effort!

A few points to consider:

• Add some documentation (to the README.md I'd guess)

  • similarly to the java_macos_integration_enable option

• Add tests (to the .github/workflows/tests.yml I'd guess)

  • This can ensure that a later feature / change does not break what You'd done

• I think You almost nailed the naming for the option:

  • starts with java_macos_integration_ - cool
  • however, I'd prefer if it was java_macos_integration_user_home

I hope the maintainer (@halcyon) should be able to help You with these, until then I'll try to test it locally, and give You feedback if I encounter some issues.

[rennsax]

@mrmeszaros Thanks for your advices! I may struggle some time to deal with the tests.

[rennsax]

I find this repo is not maintained anymore, and I personally do not use asdf now. Closed.

[halcyon]

I'm sorry to hear you feel that way.

On Mon, Sep 23, 2024 at 11:01 PM Bojun Ren @.***> wrote:

I find this repo is not maintained anymore, and I personally did not use asdf now. Closed.

— Reply to this email directly, view it on GitHub https://github.com/halcyon/asdf-java/pull/221#issuecomment-2370014889, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAABMPCOMZ6TQMLUFEL4MH3ZYDIZBAVCNFSM6AAAAABDZ3CKP2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZQGAYTIOBYHE . You are receiving this because you were mentioned.Message ID: @.***>

[halcyon]

A ping saying you felt this PR was ready to merge would have very likely gotten my attention. I can certainly understand that you may have found something that fits your needs better than ASDF.

[halcyon]

@rennsax thank you.