search

halcyon / asdf-java

A Java plugin for asdf-vm.
MIT License
454 stars 86 forks source link

Add support for SapMachine #44

Closed joschi closed 4 years ago

joschi commented 4 years ago

SapMachine is an OpenJDK release maintained and supported by SAP.

https://sap.github.io/SapMachine/

halcyon commented 4 years ago

@joschi Are these failures specific to travis? Is travis redundant now that we are using github actions?

joschi commented 4 years ago

I'm not sure about the build failures of this PR. It works on my machine with macOS and in a Docker container with Ubuntu Linux.

This being said, I'll check this PR again over the weekend, so let's not merge it for now.

And yes, I think Travis CI build jobs could be removed in favor of GitHub actions.

joschi commented 4 years ago

@halcyon Sorry for the long delay. This PR is working now as expected. 😃

joschi commented 4 years ago

Would be nice if retrieve-sapmachine() was generic and supported retrieving Github Releases from other Github repos.

@halcyon I thought the same. Either that or "caching" the result for all JVM flavors with a scheduled GitHub action (cron job) in this or in a separate repository, so that we can reduce the number of remote requests on the clients.

What do you think about the latter? Would it make sense to implement that?

halcyon commented 4 years ago

Would be nice if retrieve-sapmachine() was generic and supported retrieving Github Releases from other Github repos.

@halcyon I thought the same. Either that or "caching" the result for all JVM flavors with a scheduled GitHub action (cron job) in this or in a separate repository, so that we can reduce the number of remote requests on the clients.

What do you think about the latter? Would it make sense to implement that?

That's an interesting idea - I'll have to think about it some more, but I think I favor caching on the client side

halcyon commented 4 years ago

Thank you!