search

haleaurelian / proteusproject

Automatically exported from code.google.com/p/proteusproject
0 stars 0 forks source link

IdentityPersistenceBaseTests.AllPublicPropertiesAreDeclaredVirtual() #5

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
This test always succeeds, as per the "TODO" comment.  Here's why:

http://msdn.microsoft.com/en-us/library/system.reflection.methodbase.isvirtual.a
spx

Change the test condition to:
if (!methodInfo.IsVirtual || methodInfo.IsFinal)

Original issue reported on code.google.com by andre_lo...@hotmail.com on 2 Dec 2010 at 7:08

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for a) noticing that TODO comment I left in there so long ago, b) 
reminding me of it, c) identifying the solution, and d) taking the time provide 
a patch for the issue.

Original comment by sboh...@gmail.com on 3 Dec 2010 at 1:52

GoogleCodeExporter commented 8 years ago 
patch applied; fixed in r27.

Original comment by sboh...@gmail.com on 3 Dec 2010 at 3:01