search

halestudio / hale-cli

hale command line interface
GNU Lesser General Public License v3.0
1 stars 6 forks source link

use hale-core libraries and add formatting rules #153

Closed stempler closed 3 months ago

stempler commented 3 months ago

Build works for me but when I try to use the output in a Gradle build with gradle-hale-plugin, I get the exception below.

@florianesser Right now there seem to be three dependencies with the OSGi version class in hale-core:

But all of these seem to have the compareTo method with the signature as expected. Not sure if the conflict related to multiple versions of the class being on the classpath could be an issue.

florianesser commented 3 months ago

Running hale-cli with JAVA_OPTS="-verbose:class" gives me this line

[1,846s][info][class,load] org.osgi.framework.Version source: file:/tmp/hale-5.4.0-SNAPSHOT/lib/org.semanticweb.owlapi.osgi.skos-3.0.0.jar

Does org.osgi.framework maybe need to be excluded for the org.semanticweb.owlapi.osgi.skos dependency?

florianesser commented 3 months ago

Does org.osgi.framework maybe need to be excluded for the org.semanticweb.owlapi.osgi.skos dependency?

Removing the org/osgi folder from org.semanticweb.owlapi.osgi.skos-3.0.0.jar solved the problem for me. As far as I can see, this JAR in hale-platform is the source. As it's included as a JAR, I assume we would need to remove the folder from there, potentially together with org.osgi.core-1.4.0.jar. Or is there a way to exclude it with bnd that I'm missing?

stempler commented 3 months ago

Did some changes here to exclude/hide the OSGI dependencies in the SKOS library: https://github.com/halestudio/hale-core/pull/55

Also added an integration test running a simple transformation (failed before, now succeeds) and a test that verifies the functionality of the modified SKOS I/O bundle.

florianesser commented 3 months ago

Nice solution! LGTM now

we-release[bot] commented 2 months ago

:tada: This PR is included in version 6.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: