Should IDbExecutor derive from IDisposable?

half-ogre / dapper-wrapper

A simple abstraction atop the Dapper extension methods and TransactionScope for testability.

MIT License

70 stars 35 forks source link

Should IDbExecutor derive from IDisposable? #12

Open martinjt opened 9 years ago

martinjt commented 9 years ago

You've added a .Dispose, however, I'm unable to use this in a using statement as you would with an IDbConnection... if you derive it from IDisposable, that pattern should work (I think).

Is there a reason to not do that?

sjwoodard commented 9 years ago

IDbExecutor is an IDisposable, so it should work properly.

half-ogre commented 4 years ago

As I am sure you have already gathered from me neglecting issues on this repo, I am no longer (and haven't been for years) maintaining this library. I apologize it has taken me this long to properly respond to this to let you know, and to archive this repo.