search

half-ogre / dapper-wrapper

A simple abstraction atop the Dapper extension methods and TransactionScope for testability.
MIT License
70 stars 35 forks source link

Broken dependency on Dapper 1.8 #15

Closed RobertTheGrey closed 8 years ago

RobertTheGrey commented 8 years ago

I know it's been baked for a long time, but my DI container is throwing a nasty error from time to time - not always, but it's annoying when it happens:

System.IO.FileNotFoundException: Could not load file or assembly 'Dapper, Version=1.8.0.0, Culture=neutral, PublicKeyToken=null' or one of its dependencies. The system cannot find the file specified.
   at DapperWrapper.SqlExecutor.Query(String sql, Object param, IDbTransaction transaction, Boolean buffered, Nullable`1 commandTimeout, Nullable`1 commandType)

Seem that Dapper Wrapper take a dependency on Dapper v1.8 which doesn't exist. This can be seen in the Nuget dependecy graph as well as in the source code here itself and I'm just wondering why that is the case? Was there once upon a time a v1.8 of Dapper that disappeared?

Anyway, I thought I'd mention the issue that is throwing up on some projects since I think it's something that could quite easily be fixed. If you're accepting PRs for that kind of thing, I'd be happy to provide.

RobertTheGrey commented 8 years ago

Sorry - I see this is a mistake on my part - I misread the version of Dapper I have which is 1.42.0 which I mistakenly read as 1.4.2. No need to make any changes - I will just use an assembly redirect. Thanks