half-ogre / dapper-wrapper

A simple abstraction atop the Dapper extension methods and TransactionScope for testability.
MIT License
70 stars 35 forks source link

Use IDbConnection instead of SqlConnection #3

Closed davidduffett closed 10 years ago

davidduffett commented 12 years ago

Allows usage of classes that don't derive from SqlConnection, such as ProfiledDbConnection

PureKrome commented 10 years ago

@half-ogre any reason why this hasn't been accepted?

half-ogre commented 10 years ago

@PureKrome Sorry, didn't even realize it was sitting out here; for some reason I wasn't watching this repo!?. It seems a bit odd to me to take an IDbConection on a SqlExecutor. I think I should probably also rename SqlExecutor, but I'll merge this for now and do that later.

PureKrome commented 10 years ago

Agreed :) :+1: DbExecutor?

half-ogre commented 10 years ago

DbExecutor?

Yep.

half-ogre commented 10 years ago

(Also, so sorry I didn't see this originally @davidduffett!)

davidduffett commented 10 years ago

No problemo - got there in the end!