Closed eldar closed 11 months ago
Hi Eldar, Thanks for checking out our paper!
The gradient calculation can be found here: modules/grid_sample_Cinf.py
This special grid sample operator is used here: fields/tensoRF.py
The files you found are not used. I’ll try to get around to deleting them.
Thanks for the prompt response! There might still be typo in the code though, grid_sample2
used in https://github.com/half-potato/nmf/blob/main/fields/tensoRF.py#L255 is not defined anywhere.
Edit: Ignore the above, I should be looking at the TensoRF class not Triplanar.
Hi, congrats on a really awesome paper! I am particularly curious about how you compute normals on a tri-plane/TensoRF representation. In the paper you write:
I was able to trace the implementation to the
Triplanar
andConvolver
classes: https://github.com/half-potato/nmf/blob/main/fields/triplanar.py#L101 and https://github.com/half-potato/nmf/blob/main/modules/convolver.py#L52However it seems that
Triplanar
class is not referenced in any of the experiments and never imported by other modules in the codebase. I just wanted to confirm whether this code is indeed the reference model, because the codebase also contains code to compute gradients with autograd https://github.com/half-potato/nmf/blob/main/fields/tensor_base.py#L119Cheers, Eldar.