search

halfbaked / grails-font-awesome-resources

Provides the twitter bootstrap compatible awesome font based icon set font-awesome.
Apache License 2.0
8 stars 17 forks source link

Can we get a FA 4.1 flavor? #24

Open eliasisrael opened 10 years ago

eliasisrael commented 10 years ago

Any chance of a FA 4.1 flavor?

steffengates commented 10 years ago

I second this!

halfbaked commented 10 years ago

I'll try set aside some time, but if you can issue a pull request it would be most expedient.

On 4 August 2014 17:07, Steffen Gates notifications@github.com wrote:

I second this!

— Reply to this email directly or view it on GitHub https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51072604 .

steffengates commented 10 years ago

I'll see if I can get it working for ya!

Thanks!

--Steffen

On Aug 4, 2014, at 11:40 AM, halfbaked notifications@github.com wrote:

I'll try set aside some time, but if you can issue a pull request it would be most expedient.

On 4 August 2014 17:07, Steffen Gates notifications@github.com wrote:

I second this!

— Reply to this email directly or view it on GitHub https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51072604 .

— Reply to this email directly or view it on GitHub.

steffengates commented 10 years ago

So, I got it working, but I have a question before I do a pull request - In the current state of master, the font files are located in web-app/fonts, but if you actually install the plugin, resources complains that they're not located in web-app/css/fonts.

I went ahead and moved them, to where resources expected, but I was concerned this might do something weird to the asset pipeline. We don't currently use asset-pipeline -- do I need to look into changing the FontAwesomeResourcesGrailsPlugin file around a bit instead of moving the font files?

--Steffen

On Aug 4, 2014, at 11:41 AM, Steffen Gates graphic_innovations@mac.com wrote:

I'll see if I can get it working for ya!

Thanks!

--Steffen

On Aug 4, 2014, at 11:40 AM, halfbaked notifications@github.com wrote:

I'll try set aside some time, but if you can issue a pull request it would be most expedient.

On 4 August 2014 17:07, Steffen Gates notifications@github.com wrote:

I second this!

— Reply to this email directly or view it on GitHub https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51072604 .

— Reply to this email directly or view it on GitHub.

halfbaked commented 10 years ago

Hey Stefan, that's great news. I haven't used the asset.. plugin myself. Can you commit, push and issue the pull request, and then I'll review. I think it would be better to tweak the css rather than move the location of the fonts. Looking at the latest version, it's defined in the first few lines. thanks, Eamonn

On 4 August 2014 18:35, Steffen Gates notifications@github.com wrote:

So, I got it working, but I have a question before I do a pull request - In the current state of master, the font files are located in web-app/fonts, but if you actually install the plugin, resources complains that they're not located in web-app/css/fonts.

I went ahead and moved them, to where resources expected, but I was concerned this might do something weird to the asset pipeline. We don't currently use asset-pipeline -- do I need to look into changing the FontAwesomeResourcesGrailsPlugin file around a bit instead of moving the font files?

--Steffen

On Aug 4, 2014, at 11:41 AM, Steffen Gates graphic_innovations@mac.com wrote:

I'll see if I can get it working for ya!

Thanks!

--Steffen

On Aug 4, 2014, at 11:40 AM, halfbaked notifications@github.com wrote:

I'll try set aside some time, but if you can issue a pull request it would be most expedient.

On 4 August 2014 17:07, Steffen Gates notifications@github.com wrote:

I second this!

— Reply to this email directly or view it on GitHub < https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51072604>

.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51083875 .

steffengates commented 10 years ago

Alright, I'll see what I can do! Pull request coming in a bit once I finish testing. (from quad64bit)

--Steffen

On Aug 4, 2014, at 12:38 PM, halfbaked notifications@github.com wrote:

Hey Stefan, that's great news. I haven't used the asset.. plugin myself. Can you commit, push and issue the pull request, and then I'll review. I think it would be better to tweak the css rather than move the location of the fonts. Looking at the latest version, it's defined in the first few lines. thanks, Eamonn

On 4 August 2014 18:35, Steffen Gates notifications@github.com wrote:

So, I got it working, but I have a question before I do a pull request - In the current state of master, the font files are located in web-app/fonts, but if you actually install the plugin, resources complains that they're not located in web-app/css/fonts.

I went ahead and moved them, to where resources expected, but I was concerned this might do something weird to the asset pipeline. We don't currently use asset-pipeline -- do I need to look into changing the FontAwesomeResourcesGrailsPlugin file around a bit instead of moving the font files?

--Steffen

On Aug 4, 2014, at 11:41 AM, Steffen Gates graphic_innovations@mac.com wrote:

I'll see if I can get it working for ya!

Thanks!

--Steffen

On Aug 4, 2014, at 11:40 AM, halfbaked notifications@github.com wrote:

I'll try set aside some time, but if you can issue a pull request it would be most expedient.

On 4 August 2014 17:07, Steffen Gates notifications@github.com wrote:

I second this!

— Reply to this email directly or view it on GitHub < https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51072604>

.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51083875 .

— Reply to this email directly or view it on GitHub.

steffengates commented 10 years ago

You probably were notified already, but I just submitted a pull request. It works just fine in my local environment, but you'll of course want to follow your own testing procedures after upgrading. I hope this helps, and thanks for providing a very useful plugin!

--Steffen

On Aug 4, 2014, at 12:38 PM, halfbaked notifications@github.com wrote:

Hey Stefan, that's great news. I haven't used the asset.. plugin myself. Can you commit, push and issue the pull request, and then I'll review. I think it would be better to tweak the css rather than move the location of the fonts. Looking at the latest version, it's defined in the first few lines. thanks, Eamonn

On 4 August 2014 18:35, Steffen Gates notifications@github.com wrote:

So, I got it working, but I have a question before I do a pull request - In the current state of master, the font files are located in web-app/fonts, but if you actually install the plugin, resources complains that they're not located in web-app/css/fonts.

I went ahead and moved them, to where resources expected, but I was concerned this might do something weird to the asset pipeline. We don't currently use asset-pipeline -- do I need to look into changing the FontAwesomeResourcesGrailsPlugin file around a bit instead of moving the font files?

--Steffen

On Aug 4, 2014, at 11:41 AM, Steffen Gates graphic_innovations@mac.com wrote:

I'll see if I can get it working for ya!

Thanks!

--Steffen

On Aug 4, 2014, at 11:40 AM, halfbaked notifications@github.com wrote:

I'll try set aside some time, but if you can issue a pull request it would be most expedient.

On 4 August 2014 17:07, Steffen Gates notifications@github.com wrote:

I second this!

— Reply to this email directly or view it on GitHub < https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51072604>

.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/halfbaked/grails-font-awesome-resources/issues/24#issuecomment-51083875 .

— Reply to this email directly or view it on GitHub.