suggestion for linting - Githubissues

Alexey-T commented 3 years ago

May we add an option "linting" (str)?

empty str - don't do linting
if value has 'b' - place bookmarks w/o the line BG color - usefull for user to jump by bookmarks
if value has 'd' - place gutter-decoration marks (ed.decor)
if value has 'c' - place colored ed.attr attribs with red underlines ('red'==themed)

Alexey-T commented 3 years ago

And

if value has 'B' (upcase) - place bookmarks with BG color

halfbrained commented 3 years ago

Only ed.attr left to do, and I think I might have had a misunderstanding

* if value has 'b' - place bookmarks w/o the line BG color - usefull for user to jump by bookmarks

Should this have visible icons in the gutter? my understanding - yes => only difference between 'b' and 'c' - lack of hover-text for 'c' ... is this correct?

Alexey-T commented 3 years ago

yes, placing bookmarks is call ed.bookmark() which can run with BG color or w/o BG color (COLOR_NONE). it will add an icon. it is custom icon (BOOKMARK_SETUP).

halfbrained commented 3 years ago

I just thought you maybe meant:

'b' - bookmark for 'go to bookmark' - without an icon (empty icon)
'd' - just icons (decor())
'bd' - icons with bookmarks

I see that I understood right the first time

Alexey-T commented 3 years ago

'b'-- bookmark with BG color == COLOR_NONE 'B'-- same with BG color !=COLOR_NONE ('B' has high proority if both 'b' and 'B' in string) 'c' - color attrs 'd' - decor

maybe allow string to have few chars at once? like 'bdc'.

Alexey-T commented 3 years ago

e.g. 'Bc' -- bookmark with color + underline attr.

halfbrained commented 3 years ago

maybe allow string to have few chars at once? like 'bdc'.

That is how I thought you meant :D

if value has ...

so yes, 'bdc' will be accepted (although here 'd' will be overridden by 'b')

Alexey-T commented 3 years ago

yes, 'd' must be overriden by 'b' and 'B', 'b' is overriden by 'B'.

halfbrained commented 3 years ago

added

"lint_type": "Bc" lint_config

"lint_type": "c" line_c

halfbrained commented 3 years ago

One moment, a bug - decor image list seems to be per-editor

Alexey-T commented 3 years ago

you chosen 'underline style with curly edges'. why? can we have the style of underline as Int option? with default "- - - - lines'.

halfbrained commented 3 years ago

I wanted the 'wave', but chose wrong and didn't notice :D

Are you sure such a minor thing warrants an option? Easy to do, but I think it will just clutter the config.

Alexey-T commented 3 years ago

i think yes-- 4 good styles:

solid line
dotted line
line - - - - -
wave

halfbrained commented 3 years ago

dsah

I think there is something wrong with my dashes :D is this a bug or am I expecting too much from a dash?

border_down=2

Alexey-T commented 3 years ago

that may be painted by Lazarus and it's OS-specific line, so its OK

halfbrained commented 3 years ago

done

(for now I found another bug in diffs)

Alexey-T commented 3 years ago

I cannot find any lint-marks in plugin HTML_Tooltips, do you see them?

halfbrained commented 3 years ago

I do. Did you install linter module? pyflakes

Alexey-T commented 3 years ago

I did not. sorry

Alexey-T commented 3 years ago

Is the work slower (Py, C#) when linting is used? if it is, let's turn off option by default.

halfbrained commented 3 years ago

Nope, really fast

halfbrained / cuda_lsp

suggestion for linting #73