Move database and SSO config to env vars

halfer / awooga-app

Web application to report coding tutorials of non-optimal quality

0 stars 0 forks source link

Move database and SSO config to env vars #2

Closed halfer closed 9 years ago

halfer commented 9 years ago

The database and SSO configuration is hardwired whilst the project is in prototype stage, need to move this to vhost config.

Edited: I added SSO config in here, they are both subject to the same env requirements and security issues.

halfer commented 9 years ago

This is done for the app, still need to do this for the test classes.

PeeHaa commented 9 years ago

Please reconsider this. Not everybody has control over the vhosts and not everybody can or wants to use .htaccess files.

Instead I would suggest to use some config file in the root of the project instead that gets included.

halfer commented 9 years ago

I've made a couple of fixes here:

Test connection credentials now come from file config, previously hardwired
SSO config can now be set in file config instead, previously vhost only

@PeeHaa: I will probably still support vhost env database settings in the future, but if I do that it will be an addition rather than a replacement for file config, as per your comment. Not critical for now, so am closing.