search

halfhp / androidplot

Charts and plots for Android
http://androidplot.com
Apache License 2.0
511 stars 159 forks source link

Method Canvas.save(int) has been removed from Android SDK (API 28) #80

Closed AnthonyStephan closed 6 years ago

AnthonyStephan commented 6 years ago

My app uses Android Plot for a simple XY plot (lines).

Just updated to API 28 (targetSdkVersion and compileSdkVersion)

It does not build anymore, see the output:

Warning: com.androidplot.pie.PieRenderer: can't find referenced method 'int save(int)' in library class android.graphics.Canvas Warning: com.androidplot.ui.LayoutManager: can't find referenced method 'int save(int)' in library class android.graphics.Canvas Warning: com.androidplot.ui.SeriesRenderer: can't find referenced method 'int save(int)' in library class android.graphics.Canvas Warning: com.androidplot.ui.widget.TextLabelWidget: can't find referenced method 'int save(int)' in library class android.graphics.Canvas Warning: com.androidplot.xy.LineAndPointRenderer: can't find referenced method 'int save(int)' in library class android.graphics.Canvas Warning: com.androidplot.xy.XYGraphWidget: can't find referenced method 'int save(int)' in library class android.graphics.Canvas

In fact Canvas.save(int) has been removed from the SDK in API 28. In was deprecated since 28, now it is fully removed and you should call Canvas.save() instead

halfhp commented 6 years ago

Thx @AnthonyStephan - will get this resolved ASAP

AnthonyStephan commented 6 years ago

Great, thank you @halfhp for your great work :) Don't be in a hurry, only a few devices have access to Android P for the moment ;) and not sure a lot of devs are compiling using API 28 yet.

halfhp commented 6 years ago

Fixed in 1.5.6

AnthonyStephan commented 6 years ago

Hello Nick,

Thank a lot for your reactivity! V1.5.6 will be integrate ASAP in Printoid for OctoPrint

On Sat, 18 Aug 2018, 21:36 Nick Fellows, notifications@github.com wrote:

Fixed in 1.5.6

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/halfhp/androidplot/issues/80#issuecomment-414081527, or mute the thread https://github.com/notifications/unsubscribe-auth/AnNd0NoetpMimGaEg9zQMnxk12abwi68ks5uSGyigaJpZM4V8CSw .