halfmarble / hm-panelizer

a simple PCB panelizer
MIT License
122 stars 14 forks source link

No silk layers in OSHPark preview #4

Closed gerard-hm closed 2 years ago

gerard-hm commented 2 years ago

Describe the bug No silk layers in OSHPark preview

To Reproduce Rotate the board horizontally and export (works if not rotated)

gerard-hm commented 2 years ago

The following "breaks" silk rendering in OSHPark:

%MOMM% %FSLAX46Y46% %IPPOS% %AMMACR 21,1,$1,$2,0,0,90 1,0,0,0,0,90% %ADD11MACR,4.0X1.0% G01 %LPD% D11 X15000000Y29000000D03 %LPC% D11 X20000000Y29000000D03 M02*

gerard-hm commented 2 years ago

The problem seems to be the macro:

%AMMACR* 21,1,$1,$2,0,0,90* 1,0,0,0,0,90*%

if we remove the 2nd instruction (NOP?) like so:

%AMMACR* 21,1,$1,$2,0,0,90*%

then it works fine.

No idea why the original code at https://github.com/opiopan/pcb-tools-extension/blob/ca23fbd9534ab3cba3fd7b032816766c1150ebf9/gerberex/gerber_statements.py#L21 has it (some sort of a workaround?)

gerard-hm commented 2 years ago

git commit -m "fix bug that broke OSHPark silk rendering"

[main 276e2a9] fix bug that broke OSHPark silk rendering 3 files changed, 36 insertions(+), 22 deletions(-)