search

halfmarble / hm-panelizer

a simple PCB panelizer
MIT License
122 stars 14 forks source link

OSHPark, JLCPCB (others) do not support rotated macros #5

Closed gerard-hm closed 2 years ago

gerard-hm commented 2 years ago

Describe the bug PCB panel rotated horizontally will produce with messed up pads

Expected behavior expected

Actual behavior actual

Desktop (please complete the following information):

gerard-hm commented 2 years ago

Turns out some Pcb houses do not support rotated instructions in macros.

We need to flip (rotate by 90 to the right) in some other way - we will swap macros arguments and rotate the coordinates instead.

This requires knowing specifics of macros. Built-in ones and RoundRect (as used by KiCad) are the only one supported.

gerard-hm commented 2 years ago

git commit -m "flip board without using rotate parameter in macro instructions"

[main 86cb3a3] flip board without using rotate parameter in macro instructions 4 files changed, 58 insertions(+), 23 deletions(-)