search

halfmoonui / halfmoon

Halfmoon is a highly customizable, drop-in Bootstrap replacement. It comes with three built-in core themes, with dark mode support for all themes and components.
https://www.gethalfmoon.com
MIT License
3.04k stars 118 forks source link

xxl breakpoint size? #19

Open ixahmedxi opened 4 years ago

ixahmedxi commented 4 years ago

Hello,

First of all awesome framework, great job! I have a small suggestion, with the increased resolution of screens, it seems like 1200px as a max breakpoint is a bit too small. Bootstrap v5 introduces a new breakpoint (xxl) which is 1400px. I think this breakpoint could be a great addition as that it will be nicer on high resolution screens. I can help out with creating this.

Thanks!

halfmoonui commented 4 years ago

Hey, thanks for bringing this up. Halfmoon auto-scales up everything when the screen size gets bigger than 1600px. You can see it in this image: Image link

Do you feel this removes the need for the xxl breakpoint you are suggesting? I would love some more opinions too if possible.

ixahmedxi commented 4 years ago

Oh sorry for not mentioning, I was talking about the .container class, it says in the docs that Extra large (1200px) is the largest breakpoint so I am suggesting to add another one (Extra Extra large) 1400px for that class.

halfmoonui commented 4 years ago

Only adding an extra extra large .container does not make sense to me. It has to be a full breakpoint if it is to be added.

ixahmedxi commented 4 years ago

yes of course not only for .container but for anything that gets a restricted widths based on breakpoints like .container.