search

halfmoonui / halfmoon

Halfmoon is a highly customizable, drop-in Bootstrap replacement. It comes with three built-in core themes, with dark mode support for all themes and components.
https://www.gethalfmoon.com
MIT License
3.04k stars 118 forks source link

Added Progress Bars #22

Closed Hoppi164 closed 4 years ago

Hoppi164 commented 4 years ago

Hi there

I've created this pull request to address this enhancement/issue requesting "Progress Indicator Components" https://github.com/halfmoonui/halfmoon/issues/7

The progress bar's I've implemented are a near clone of the equivalent bootstrap components, with a dark mode implementation improvement, to keep these components inline with the rest of Halfmoon.

I've also add an example progress bar section in the "Starter Template.html" as i was unable to find/modify the documentation file.

Please let me know if you'd like me to approach pull requests in a different way, or if there's anything you'd like modified in this pull request.

Light Mode image

Dark Mode image

halfmoonui commented 4 years ago

Hey, first of all thank you for contributing and sorry for getting back to you so late. Unfortunately, I can't accept this pull request because it modifies the starter-template.html for examples of one single component. Moreover, I feel the styling of the progress bars are not up to the par. I have added a CONTRIBUTING.md to the repo so that we can avoid cases like this one, and again, my bad, I should have added it before. As stated there though, please feel free to reach out to me at hey.halfmoon@gmail.com if you want to discuss the framework or make other contributions.

Again, I am sorry for the inconveniences.

Edit Note that progress bars have already been added to v1.1.0. That should be out this month hopefully!

Hoppi164 commented 4 years ago

Hey Halfmoon. Thanks for getting back to me.

I didn't realise you'd already added progress bars in a staged release.

I am still interested in contributing towards Halfmoon.

I'll send you an email later today, to discuss if you'd like assistance with anything, and how I can help out,