search

halfmoonui / halfmoon

Halfmoon is a highly customizable, drop-in Bootstrap replacement. It comes with three built-in core themes, with dark mode support for all themes and components.
https://www.gethalfmoon.com
MIT License
3.04k stars 118 forks source link

Inconsistent transition speeds #34

Closed Toby222 closed 4 years ago

Toby222 commented 4 years ago

Seen on Google Chrome, at the Introduction page of the Docs Toggling between dark and light theme shows that some elements have different transition speeds. The sidebar is clearly slower than the rest of the page, and the text outside of cards transitions slower than that inside

halfmoonui commented 4 years ago

Fair point. But how do you propose we fix this? The sidebar needs a transition for the toggle to be smooth. This unfortunately makes it slow during dark mode toggles.

Not sure about the text outside of the card though.

Toby222 commented 4 years ago

By giving everything else the same transition speed, or adjusting the sidebar to be quicker? The problem isn't the transition, just the difference in speed between some elements.

The text I mentioned is black-on-black for a moment when switching to dark theme, so the text transitions slower than the background

halfmoonui commented 4 years ago

Giving everything the same transition is a bad idea. You would get a delay on mundane things like the hover and focus effects on button. And the difference in speed is precisely why the sidebar toggle is so snappy. I think there might be a possible solution to this, but it would require JavaScript. Removing all the transitions is another way.

Toby222 commented 4 years ago

Maybe just adjust the transition speed for the necessary properties then?

halfmoonui commented 4 years ago

@toman222 Fixed in v1.1.0: https://www.gethalfmoon.com/docs/introduction/

I will go ahead and close this issue. You can re-open it if you think the issue is still not resolved, or open another issue.