[Fix] - fix 'buffer' reference error and add additional filter constraint to empty folders

halfwhole / luminus-downloader

Downloads files and folders from LumiNUS

MIT License

11 stars 4 forks source link

[Fix] - fix 'buffer' reference error and add additional filter constraint to empty folders #1

Closed aaronsms closed 4 years ago

aaronsms commented 4 years ago

Hi, I just happened to bump into this project, and I find it really neat, I would probably use this quite often, and suggest to someone else too. There's just some minor breaks from few months back.

And downloading empty folders is not possible from the API, so not sure how you will want to handle it. Here, I suggest skipping it directly. Picture shows the result of downloading empty folders.

Thanks!

halfwhole commented 4 years ago

Hi @aaronsms, thanks for your interest and for your contribution! It looks great, so I'll be merging it in right away.

I've also noticed those breaks that you'd mentioned, now that the new semester is here. I'll try to fix those as quickly as I can, hopefully by tonight. Thanks again for your help!