halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.87k stars 1.07k forks source link

OSX AOT builds issue dozens of weak-symbols warnings #2753

Open steven-johnson opened 6 years ago

steven-johnson commented 6 years ago

As of some recent commit, OSX builds of AOT-compiled code issue dozens of warnings of the form

ld: warning: direct access in function '_halide_can_use_target_features' from file 'bin/host/runtime.a(runtime.a.o)' to global weak symbol 'Halide::Runtime::Internal::custom_can_use_target_features' from file 'bin/host/runtime.a(runtime.a.o)' means the weak symbol

Steps to repeat:

(Will update issue when I find the injection point)

rc-conway commented 5 years ago

is there an update on this issue?

steven-johnson commented 5 years ago

Sadly, no; AFAIK no one has spent any time trying to correct it. We'd love a PR that did so, of course :-)

rc-conway commented 5 years ago

Building Halide from recent master source myself, the issue appears to be resolved using clang version 7.0.1 on MacOS 10.14.2

Possibly the issue can be closed or at least closed on the next release.