search

halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.88k stars 1.07k forks source link

OpenGL initial modules missing from Windows build #293

Closed yongyi781 closed 10 years ago

abadams commented 10 years ago

Also, opengl_windows_context is not-yet-implemented, so this won't work until we get around to doing that.

On Wed, May 14, 2014 at 2:58 PM, yongyi781 notifications@github.com wrote:

— Reply to this email directly or view it on GitHubhttps://github.com/halide/Halide/issues/293 .

jrk commented 10 years ago

I don't think Yongyi was concerned about OpenGL working on Windows, but about the build breaking altogether for him due to missing symbols.

abadams commented 10 years ago

I think I pushed a fix for that (there was a missing line in CMakeLists), but I can't test it until tonight.

On Wed, May 14, 2014 at 4:43 PM, Jonathan Ragan-Kelley < notifications@github.com> wrote:

I don't think Yongyi was concerned about OpenGL working on Windows, but about the build breaking altogether for him due to missing symbols.

— Reply to this email directly or view it on GitHubhttps://github.com/halide/Halide/issues/293#issuecomment-43152569 .

jrk commented 10 years ago

Sounds right. Not a big deal, @yongyi781 just reverted to an older revision for his work, but figured this was not an intentional build breakage so I encouraged him to report it.

Aside: I encouraged him to share a Gist with his successful simple example of using extern functions to save out a whole pyramid from a single pipeline. (This is a simple, isolated test in preparation for doing it for real in his Eulerian video magnification code. It's a nice example of clever extern function usage.)

abadams commented 10 years ago

Ok, there was a bunch of stuff missing. Works for me now.

yongyi781 commented 10 years ago

Works for me too.