search

halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.86k stars 1.07k forks source link

`debug` shouldn't print entry/exit for parallel closures (but does) #8184

Closed steven-johnson closed 5 months ago

steven-johnson commented 5 months ago

What it says on the tin -- it makes the debug feature near-useless if you have any parallelism in your schedule. Maybe it's useful for some corner cases but I haven't yet encountered such a case. Can we default it to off for these?

abadams commented 5 months ago

I think this change was unintended. It crept in when we move lowering of parallel closures into lowering instead of codegen. I agree it should be fixed.

abadams commented 5 months ago

Except the code looks like it's really just annotating the main LoweredFunc. I'll investigate.

abadams commented 5 months ago

ok, it looks like this was actually an intentional change, because code for it was added to LowerParallelTasks.cpp