search

halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.86k stars 1.07k forks source link

Insert apparently-missing `break;` in IREquality.cpp #8211

Closed steven-johnson closed 5 months ago

steven-johnson commented 5 months ago

Maybe time to enable -Wimplicit-fallthrough

abadams commented 5 months ago

Funnily enough, this could not have caused a problem other than making a redundant check, which is why no tests failed, but that's only because GE has the same layout as GT.

Looks like there's another problem in runtime/webgpu.cpp

steven-johnson commented 5 months ago

Funnily enough, this could not have caused a problem other than making a redundant check, which is why no tests failed, but that's only because GE has the same layout as GT.

Looks like there's another problem in runtime/webgpu.cpp

I did a clean CMake build and didn't get any warning there. Or did you find this by inspection?

abadams commented 5 months ago

I added the flag to the makefile build. Did adding the flag to cmake also cover the runtime?

steven-johnson commented 5 months ago

I added the flag to the makefile build. Did adding the flag to cmake also cover the runtime?

Nope, fixing now

steven-johnson commented 5 months ago

Please push your makefile fixes to this branch too