search

halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.77k stars 1.07k forks source link

Fix OpenCL positive and negative INF constants. #8266

Closed alexreinking closed 2 weeks ago

alexreinking commented 4 weeks ago

Constructs the necessary constants from the Halide::float16_t bit masks.

Fixes #8257

abadams commented 4 weeks ago

Nice avoidance of new magic numbers.

alexreinking commented 4 weeks ago

The Vulkan errors here were fixed in #8259

shoaibkamil commented 4 weeks ago

One thing that just occurred to me-- can you also modify test/correctness/gpu_f16_intrinsics.cpp to also run on OpenCL+CLHalf enabled? That should exercise these constants.

alexreinking commented 3 weeks ago

One thing that just occurred to me-- can you also modify test/correctness/gpu_f16_intrinsics.cpp to also run on OpenCL+CLHalf enabled? That should exercise these constants.

Done -- let's see how the buildbots like it.