search

halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.91k stars 1.07k forks source link

Fix for the removed DataLayout constructor. #8391

Closed mcourteaux closed 3 months ago

mcourteaux commented 3 months ago

This fixes the latest change in LLVM where the DataLayout constructor that accepts a Module is removed. https://github.com/llvm/llvm-project/commit/75c7bca740935a0cca462e28475dd6b046a6872c

CC @steven-johnson

steven-johnson commented 3 months ago

Thanks for the fix, but this needs to be conditionalized for multiple versions of LLVM. I'll upload a patch.

mcourteaux commented 3 months ago

No it doesn't, afaik. The getDataLayout() was always there. The build bots confirm that it works.

alexreinking commented 3 months ago

No it doesn't, afaik. The getDataLayout() was always there. The build bots confirm that it works.

I agree it's better to avoid #if when it's not necessary.