halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.91k stars 1.07k forks source link

Disable zstd in llvm in our llvm build instructions #8407

Closed abadams closed 2 months ago

abadams commented 2 months ago

LLVM recently started defaulting ENABLE_ZSTD to on, but on macos brew puts libzstd into a directory that's not in the linker search path, and llvm-config --system-libs declares a dependency on zstd but doesn't add the correct search path. It's not clear why we need llvm with zstd, so I'm proposing just disabling it in our build instructions to avoid this failure mode.

abadams commented 2 months ago

Are you saying we should just copy-paste the whole list in pip.yml to avoid building unnecessary things?

alexreinking commented 2 months ago

Are you saying we should just copy-paste the whole list in pip.yml to avoid building unnecessary things?

Yes, less the obviously ci-specific stuff, like the install prefix. On mobile, sorry.

alexreinking commented 2 months ago

Superseded by #8410