halide / Halide

a language for fast, portable data-parallel computation
https://halide-lang.org
Other
5.91k stars 1.07k forks source link

Fix Homebrew LLVM 19 #8431

Closed alexreinking closed 1 month ago

alexreinking commented 1 month ago

After upgrading to Homebrew's LLVM 19.1, I encountered some build failures that necessitate the following changes to our build.

  1. LLD is now packaged separately, so I needed to brew install lld.
  2. lldWasm is built as a shared library now, and it no longer includes lldCommon, so I added that dependency.
  3. LLD's headers are installed to a different folder than the rest of LLVM's now, so I added it to the include path.

Technically, this could have happened with earlier versions of LLVM, only nobody had packaged it this way, until now.

alexreinking commented 1 month ago

Also, would that LLVM fixed their CMake targets! The include directory issue wouldn't have happened if they set up their targets correctly. Also, lldWasm should probably depend on lldCommon.

steven-johnson commented 1 month ago

linuxbot4 is still semi-broken :-/