[vulkan] Fixes to address outstanding validation failures

halide / Halide

a language for fast, portable data-parallel computation

https://halide-lang.org

Other

5.91k stars 1.07k forks source link

[vulkan] Fixes to address outstanding validation failures #8448

Closed derek-gerstmann closed 3 weeks ago

derek-gerstmann commented 3 weeks ago

Fix ArrayStride for arrays of vectors bound to buffer blocks.
Make a local copy of allocators to avoid dangling references during destruction
Cleanup Vulkan Memory Allocator destruction to avoid duplicate calls to destroy block allocator

Fixes #8291 Fixes #8287 Fixes #8293

derek-gerstmann commented 3 weeks ago

Okay, this is good to go. I've been testing this on my local machine configs and this passes cleanly on Linux Ubuntu 22.04 w/Vulkan SDK v1.3.296 w/NVIDIA GeForce RTX 3070 TI.

derek-gerstmann commented 3 weeks ago

I'm also testing changes to avoid over-use of descriptor sets on resource constrained devices, but that'll be a larger PR.

abadams commented 3 weeks ago

Failure is unrelated flake