search

halilb / react-native-textinput-effects

Text inputs with custom label and icon animations for iOS and android. Built with react native and inspired by Codrops.
MIT License
2.99k stars 293 forks source link

Components wont display in RN 0.36 #14

Closed jjdp closed 7 years ago

jjdp commented 8 years ago

see https://github.com/facebook/react-native/commit/0a9b6bedb312eba22c5bc11498b1cc41363e5f27

florianbepunkt commented 8 years ago

+1

halilb commented 8 years ago

Thanks for reporting @jjdp and @florianbepunkt!

I just upgraded the example project to RN 0.36.1 but couldn't reproduce the problem. Could you guys try updating the example project and give it a try again?

florianbepunkt commented 8 years ago

I will try and check on the weekend. Curious why you couldn't reproduce this… can you share some more specs of your test? I had a fresh install of react native cli from yesterday, but had to create a project react-native version 0.36.1 due to some dependecy issues.

halilb commented 8 years ago

@florianbepunkt I just used the example project inside this repository. It's currently using 0.36.1, so you can simply clone the repo and try it out with that project.

jjdp commented 7 years ago

weird. hideo is the only one that isn't displaying. the direct parent must have a flex: 1 for it to display

halilb commented 7 years ago

@jjdp Can you check out the example project? Hideo is displayed even if it's parent doesn't have flex: 1.

jjdp commented 7 years ago

i guess its probably because of my nested views with so many flex:1. it works if i set a width and height.

halilb commented 7 years ago

This shouldn't be a problem with newer react native releases.