halilb / react-native-textinput-effects

Text inputs with custom label and icon animations for iOS and android. Built with react native and inspired by Codrops.
MIT License
2.98k stars 291 forks source link

Default Font Fixed #76

Closed JadRizk closed 5 years ago

JadRizk commented 6 years ago

Arial is not a default font in Android. This may cause a problem along the way if the font is not imported. I've tried to fix this issue by changing the default font according to the device. I've kept 'Arial' for IOS device and added 'sans-serif' (default android font) for Android users.

Hope it helped !!

halilb commented 5 years ago

Thank you very much for the contribution @JadRizk, and I'm so sorry for reviewing this after such a long time.

I just discovered that there is no use of using fontFamily for those labels and inputs as react-native will be using the default font for each platform automatically. So I'm closing this PR in favor of 5d01eae.