halilozercan / BetterVideoPlayer

Video playback on Android, made better in Kotlin, wrapping around the stock MediaPlayer API.
288 stars 94 forks source link

Missing FadingCircle of SpinKitView after adding to gradle #55

Open devingDev opened 6 years ago

devingDev commented 6 years ago

-- [ x] I have verified there are no duplicate active or recent bugs, questions, or requests -- [x ] I have verified that I am using the latest version of Better Video Player. -- [ x] I have given my issue a non-generic title. -- [ x] I have read over the documentation (before asking questions on how to do something).

-###### Include the following:

-###### Reproduction Steps

-1. Added to both gradle files what was written in README -2. Wait for gradle to sync -3. Thats it now I got that error

-###### Expected Result

UGhari commented 6 years ago

I seem to have the same problem. Is there a possible fix in the works?

srini17 commented 6 years ago

Seems like animation icons are missing.

I was able to fix the issue by using https://github.com/ybq/Android-SpinKit dependencies { compile 'com.github.ybq:Android-SpinKit:1.1.0' }

halilozercan commented 6 years ago

Library already has this dependency?

https://github.com/halilozercan/BetterVideoPlayer/blob/master/bettervideoplayer/build.gradle#L31

UGhari commented 6 years ago

Hmm that is very strange yes you already have that dependancy. I added it the spinKIT to my own project anyway just to see if it works and it does now both successfully compile. Very strange though

implementation 'com.github.halilozercan:BetterVideoPlayer:1.2.alpha1'
implementation 'com.github.ybq:Android-SpinKit:1.1.0'