halilozercan / BetterVideoPlayer

Video playback on Android, made better in Kotlin, wrapping around the stock MediaPlayer API.
288 stars 94 forks source link

Failed to resolve: com.github.halilozercan:BetterVideoPlayer:1.2.alpha1 #64

Closed NizNsm closed 5 years ago

NizNsm commented 6 years ago

Iam facing this issue while syncing the gradle

Failed to resolve: com.github.halilozercan:BetterVideoPlayer:1.2.alpha1

NizNsm commented 6 years ago

Goodness.! The issue was missing of :

allprojects {
        repositories {
            ...
            maven { url 'https://jitpack.io' }
        }
    }
ZyronAlex commented 6 years ago

Hi I'm having a similar problem, when I try to synchronize the project I get this error:

error: resource style/SpinKitView.Large.FadingCircle (aka com.tecapps.AnimeC:style/SpinKitView.Large.FadingCircle) not found.
Message{kind=ERROR, text=error: resource style/SpinKitView.Large.FadingCircle (aka com.tecapps.AnimeC:style/SpinKitView.Large.FadingCircle) not found., sources=[C:\Users\alexbelo\.gradle\caches\transforms-1\files-1.1\BetterVideoPlayer-1.2.alpha1.aar\e2f50c251a91c492666e421ad6fca080\res\layout\bvp_include_progress.xml:7], original message=, tool name=Optional.of(AAPT)}

Someone can help me ?

sriramr98 commented 6 years ago

@ZyronAlex Even I'm facing this issue. Any help would be appretiated.

piotrkalitka commented 6 years ago

Looks like there is missing dependency to https://github.com/ybq/Android-SpinKit: implementation 'com.github.ybq:Android-SpinKit:1.1.0'

After adding it, everything works fine for me.

ZyronAlex commented 6 years ago

@piotrkalitka
this dependency, is from BetterPlayer ? why do I have to add another library to use BetterPlayer, it should not be implemented internally

piotrkalitka commented 6 years ago

I am not the author of this lib, so I can't tell you why you need to implement this on manually, but this solves the problem until author will fix this in next release

ZyronAlex commented 6 years ago

Thk man, this really solves the problem

sriramr98 commented 6 years ago

Actually, this dependency is present in the library if you explore the gradle files. I don't know why it isn't working.

halilozercan commented 6 years ago

Hey guys, I'm sorry for getting back this slow.

Usually the problem is forgetting to add jitpack in repositories list.

Goodness.! The issue was missing of :

allprojects {
repositories {
...
maven { url 'https://jitpack.io' }
}
}

However, now I realize that SpinKit may also cause problems. The funny thing is that as you have already mentioned, SpinKit exists as a dependency in this library. Maybe new gradle version is causing problems, I'm not really sure.

As a result, I will probably remove this dependency and go back to default android progress style while having this progressbar customizable by the app.

malavancs commented 5 years ago

Still facing the problem