halkyonio / operator

Kubernetes Operator simplifying the development of microservices on k8s !
Apache License 2.0
40 stars 14 forks source link

[Doc]: fix demo doc to use `demo` namespace when deploying Halkyon resources #158

Closed pdettori closed 5 years ago

pdettori commented 5 years ago

I ran the demo tutorial and found that in the code snippet:

kubectl create ns demo
kubectl apply -f fruit-client-sb/target/classes/META-INF/dekorate/halkyon.yml
kubectl apply -f fruit-backend-sb/target/classes/META-INF/dekorate/halkyon.yml

the Halkyon resources get created in the default namespace, but the rest of the demo assumes that they should be in demo. So it should be instead:

kubectl create ns demo
kubectl apply -f fruit-client-sb/target/classes/META-INF/dekorate/halkyon.yml -n demo
kubectl apply -f fruit-backend-sb/target/classes/META-INF/dekorate/halkyon.yml -n demo
cmoulliard commented 5 years ago

I fixed the doc. Can you review and close if the problem is fixed please ? @pdettori

pdettori commented 5 years ago

@cmoulliard, it looks good, thx.