search

halkyonio / operator

Kubernetes Operator simplifying the development of microservices on k8s !
Apache License 2.0
40 stars 14 forks source link

[Doc]: use “minikube ip” to get the address of minikube for ingress #160

Closed pdettori closed 5 years ago

pdettori commented 5 years ago

I have run the demo and found that there is a hardcoded IP for minikube in the instructions. The minikube IP can be found with minikube ip.

So Instead of using:

export FRONTEND_ROUTE_URL=195.201.87.126

I suggest using:

export FRONTEND_ROUTE_URL=$(minikube ip)

and for MiniShift :

export FRONTEND_ROUTE_URL=fruit-client-sb-test.$(minikube ip).nip.io
cmoulliard commented 5 years ago

I propose that we add then before the examples a comment mentioning that the IP address could be found using either minishift ip or minikube ip as such commands could also be executed on a cluster not created using one of these tools

cmoulliard commented 5 years ago

I fixed the doc. Can you review and close if the problem is fixed please ? @pdettori

pdettori commented 5 years ago

@cmoulliard looks good, thx.