search

hallahan / LeafletPlayback

This is a Leaflet plug-in that plays back points that have a time stamp synchronized to a clock.
http://leafletplayback.theoutpost.io
Other
482 stars 165 forks source link

update gpx support. #43

Closed apre closed 8 years ago

apre commented 8 years ago

The already existing GPX parser have been updated. It can now import multiple-tracks files.

L.Playback.Util.ParseGPX() is now exposed in the readme file.

GeoJSON parsing now reads "FeatureCollection" elements.

hallahan commented 8 years ago

Hi @apre! This looks great! Do you have an example by any chance?

apre commented 8 years ago

I am preparing a sample file, hopefully it will be ready next week

apre commented 8 years ago

Here is the sample file!

Have a nice day :)

hallahan commented 8 years ago

Oh darn, I didn't see that you ended up adding examples.... Sorry for being super late on this!

I'm trying out your supplied GPX example, and it's not actually parsing the GPX into GeoJSON. Something isn't right.

screenshot 2016-08-04 10 12 16

I want to integrate your PR, so I'm troubleshooting...

hallahan commented 8 years ago

Any idea why this isn't working? I assume it works for you fine @apre ?

apre commented 8 years ago

Hi @hallahan, Maybe it is because you opened the sample file directly from file browser, not through a web server as mentioned in commit message c1e57b0

I have updated the samble file to directly include the gpx file in it, avoiding to load an external ressource. I have also tested in on firefox, internet explorer 11 and edge, all worked as I expected.

Have fun and feel free to come back to me in case of any issues !

apre commented 8 years ago

@hallahan ?