Bad annotation merging method

taltman commented 9 years ago

A eukaryotic annotation slipped into my bacterial reconstruction. I debugged it, and here's what happened:

I filtered ORFs and contigs based on the LCA computed by MP, which is based on RefSeq. All the RefSeq hits for the ORF were bacterial.
There was a more remote annotation found from Blasting against MetaCyc, which annotated the gene to a Eukaryotic gene

So I'm confused why the wrong annotation with the larger p-value was the one selected for inclusion in the annotation table. Seems to me that the annotation reconciliation code needs to be more transparent, and tunable.

hallamlab commented 7 years ago

More information on annotation will be included in the latest MP release coming soon

taltman commented 7 years ago

Does that mean that this issue is fixed? Or that we'll just have more transparency about the merging method?

ariahahn commented 7 years ago

both!

On Wed, Jan 4, 2017 at 4:35 PM, Tomer Altman notifications@github.com wrote:

Does that mean that this issue is fixed? Or that we'll just have more transparency about the merging method?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hallamlab/metapathways2/issues/64#issuecomment-270528597, or mute the thread https://github.com/notifications/unsubscribe-auth/AI6RqF2BnhiJH6vgt3KevxQkBZdWFolBks5rPDq3gaJpZM4D4z2R .

-- Aria Hahn MSc PhD Candidate www.cupcakesandscience.com Hallam Laboratory http://www.cmde.science.ubc.ca/hallam/index.php

University of British Columbia Department of Microbiology & Immunology Life Sciences Centre 2350 Health Sciences Mall (Rm 2520) Vancouver, BC Canada V6T 1Z3 T: 604-827-4216 F: 604-822-6041 ariahahn@interchange.ubc.ca

hallamlab / metapathways2

Bad annotation merging method #64