search

hallatore / Netling

Netling is a load tester client for easy web testing.
MIT License
1.34k stars 210 forks source link

ensure text is visible for those with red-green color blindness #15

Closed shanselman closed 7 years ago

hallatore commented 7 years ago

Right now it's just Red and Green, I think it's ok if both look equal as long as they are still readable.

@shanselman Any online tests I can use to ensure this?

chezuma commented 7 years ago

http://littlebigdetails.com/post/35775193711/trello-color-blind-friendly-mode-makes

This did wonders for me when using Trello! Yes, I am red/green colorblind.

hallatore commented 7 years ago

@chezuma How is your experience using Netling? Are the red/green values the same? And any input on what you would do to fix it?

chezuma commented 7 years ago

Unfortunately for me, they are easily mixed. The red ones doesn't stand out. Using blues instead of greens is always a neat trick, makes it a lot easier.

jnm2 commented 7 years ago

I think red/green is the most compelling visual, so I'd want that to be default and colorblind mode could be opted in.

SecretDeveloper commented 7 years ago

How about including a non colour element to also indicate success/improvement. Something like a Tick icon or Up/Down arrows?

ChristopherGLewis commented 7 years ago

I've got a pretty simple hash background for the ValueUserControl that solves this here: https://github.com/ChristopherGLewis/Netling

image

hallatore commented 7 years ago

Nice. I will check it out.

But I won't implement it as an option. The default implementation has to work for all.

ChristopherGLewis commented 7 years ago

Its actually just a small change to the ValueUserControl to toggle a background VisualBrush. Its a new property (UseADA) that defaults to false. When set to true, it sets the VisualBrush background to visible.

I added a checkbox to the ResultWindow that toggles the ValueUserControl.UseADA value for all the items.

BNDKPNTR commented 7 years ago

Hi, I also created a version where you can change between red-green and red-blue colors, and the selected option is saved so you dont have to change it at every startup.

https://github.com/BNDKPNTR/Netling

capture
hallatore commented 7 years ago

Here is my test so far. Is this enough or easy to miss?

chezuma commented 7 years ago

The blue/red one is awesome for me, but the red striped one works just as good.

Now its just a matter of taste :) great work to both of you, make them each an option :D

The one with the grid in the background was just to noisy for my eyes anyways.

hallatore commented 7 years ago

I've added the one from the screenshot above. It should work well enough while still following the theme I have for the app.

PS: Let me know if it still needs tweaking. :)

ChristopherGLewis commented 7 years ago

Looks great - My only suggestion would be to move the VisualBrush to the UserControl to better allow the control to be reused.